lkml.org 
[lkml]   [2020]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5.10 527/717] media: ipu3-cio2: Validate mbus format in setting subdev format
Hi!

> commit a86cf9b29e8b12811cf53c4970eefe0c1d290476 upstream.
>
> Validate media bus code, width and height when setting the subdev format.
>
> This effectively reworks how setting subdev format is implemented in the
> driver.

Something is wrong here:

> + fmt->format.code = formats[0].mbus_code;
> + for (i = 0; i < ARRAY_SIZE(formats); i++) {
> + if (formats[i].mbus_code == fmt->format.code) {
> + fmt->format.code = mbus_code;
> + break;
> + }

This does not make sense. Loop will always exit during the first
iteration, making the whole loop crazy/redundant.

Best regards,
Pavel

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-12-30 13:27    [W:1.582 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site