lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 646/717] spi: davinci: Fix use-after-free on unbind
    Date
    From: Lukas Wunner <lukas@wunner.de>

    commit 373afef350a93519b4b8d636b0895da8650b714b upstream.

    davinci_spi_remove() accesses the driver's private data after it's been
    freed with spi_master_put().

    Fix by moving the spi_master_put() to the end of the function.

    Fixes: fe5fd2540947 ("spi: davinci: Use dma_request_chan() for requesting DMA channel")
    Signed-off-by: Lukas Wunner <lukas@wunner.de>
    Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
    Cc: <stable@vger.kernel.org> # v4.7+
    Link: https://lore.kernel.org/r/412f7eb1cf8990e0a3a2153f4c577298deab623e.1607286887.git.lukas@wunner.de
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/spi/spi-davinci.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/spi/spi-davinci.c
    +++ b/drivers/spi/spi-davinci.c
    @@ -1040,13 +1040,13 @@ static int davinci_spi_remove(struct pla
    spi_bitbang_stop(&dspi->bitbang);

    clk_disable_unprepare(dspi->clk);
    - spi_master_put(master);

    if (dspi->dma_rx) {
    dma_release_channel(dspi->dma_rx);
    dma_release_channel(dspi->dma_tx);
    }

    + spi_master_put(master);
    return 0;
    }


    \
     
     \ /
      Last update: 2020-12-28 15:33    [W:2.826 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site