lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 683/717] iio:adc:ti-ads124s08: Fix buffer being too long.
    Date
    From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

    commit b0bd27f02d768e3a861c4e6c27f8e369720e6c25 upstream.

    The buffer is expressed as a u32 array, yet the extra space for
    the s64 timestamp was expressed as sizeof(s64)/sizeof(u16).
    This will result in 2 extra u32 elements.
    Fix by dividing by sizeof(u32).

    Fixes: e717f8c6dfec ("iio: adc: Add the TI ads124s08 ADC code")
    Signed-off-by: Jonathan Cameron<Jonathan.Cameron@huawei.com>
    Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
    Cc: Dan Murphy <dmurphy@ti.com>
    Cc: <Stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/20200920112742.170751-8-jic23@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/iio/adc/ti-ads124s08.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/iio/adc/ti-ads124s08.c
    +++ b/drivers/iio/adc/ti-ads124s08.c
    @@ -269,7 +269,7 @@ static irqreturn_t ads124s_trigger_handl
    struct iio_poll_func *pf = p;
    struct iio_dev *indio_dev = pf->indio_dev;
    struct ads124s_private *priv = iio_priv(indio_dev);
    - u32 buffer[ADS124S08_MAX_CHANNELS + sizeof(s64)/sizeof(u16)];
    + u32 buffer[ADS124S08_MAX_CHANNELS + sizeof(s64)/sizeof(u32)];
    int scan_index, j = 0;
    int ret;


    \
     
     \ /
      Last update: 2020-12-28 15:34    [W:3.035 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site