lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 121/717] media: mtk-vcodec: add missing put_device() call in mtk_vcodec_release_dec_pm()
    Date
    From: Yu Kuai <yukuai3@huawei.com>

    [ Upstream commit 27c3943683f74e35e1d390ceb2e3639eff616ad6 ]

    mtk_vcodec_release_dec_pm() will be called in two places:

    a. mtk_vcodec_init_dec_pm() succeed while mtk_vcodec_probe() return error.
    b. mtk_vcodec_dec_remove().

    In both cases put_device() call is needed, since of_find_device_by_node()
    was called in mtk_vcodec_init_dec_pm() previously.

    Thus add put_devices() call in mtk_vcodec_release_dec_pm()

    Fixes: 590577a4e525 ("[media] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver")
    Signed-off-by: Yu Kuai <yukuai3@huawei.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c
    index f6a6b42865fbd..ddee7046ce422 100644
    --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c
    +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c
    @@ -85,6 +85,7 @@ put_device:
    void mtk_vcodec_release_dec_pm(struct mtk_vcodec_dev *dev)
    {
    pm_runtime_disable(dev->pm.dev);
    + put_device(dev->pm.larbvdec);
    }

    void mtk_vcodec_dec_pw_on(struct mtk_vcodec_pm *pm)
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 16:16    [W:3.181 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site