lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 311/717] dm ioctl: fix error return code in target_message
    Date
    From: Qinglang Miao <miaoqinglang@huawei.com>

    [ Upstream commit 4d7659bfbe277a43399a4a2d90fca141e70f29e1 ]

    Fix to return a negative error code from the error handling
    case instead of 0, as done elsewhere in this function.

    Fixes: 2ca4c92f58f9 ("dm ioctl: prevent empty message")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
    Signed-off-by: Mike Snitzer <snitzer@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/md/dm-ioctl.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
    index cd0478d44058b..5e306bba43751 100644
    --- a/drivers/md/dm-ioctl.c
    +++ b/drivers/md/dm-ioctl.c
    @@ -1600,6 +1600,7 @@ static int target_message(struct file *filp, struct dm_ioctl *param, size_t para

    if (!argc) {
    DMWARN("Empty message received.");
    + r = -EINVAL;
    goto out_argv;
    }

    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 16:09    [W:2.073 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site