lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 153/717] spi: mxs: fix reference leak in mxs_spi_probe
    Date
    From: Zhang Qilong <zhangqilong3@huawei.com>

    [ Upstream commit 03fc41afaa6549baa2dab7a84e1afaf5cadb5b18 ]

    pm_runtime_get_sync will increment pm usage counter even it
    failed. Forgetting to pm_runtime_put_noidle will result in
    reference leak in mxs_spi_probe, so we should fix it.

    Fixes: b7969caf41a1d ("spi: mxs: implement runtime pm")
    Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
    Link: https://lore.kernel.org/r/20201106012421.95420-1-zhangqilong3@huawei.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/spi/spi-mxs.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
    index 918918a9e0491..435309b09227e 100644
    --- a/drivers/spi/spi-mxs.c
    +++ b/drivers/spi/spi-mxs.c
    @@ -607,6 +607,7 @@ static int mxs_spi_probe(struct platform_device *pdev)

    ret = pm_runtime_get_sync(ssp->dev);
    if (ret < 0) {
    + pm_runtime_put_noidle(ssp->dev);
    dev_err(ssp->dev, "runtime_get_sync failed\n");
    goto out_pm_runtime_disable;
    }
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 16:39    [W:4.122 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site