lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 216/717] RDMA/hns: Avoid setting loopback indicator when smac is same as dmac
    Date
    From: Weihang Li <liweihang@huawei.com>

    [ Upstream commit 3631dadfb118821236098a215e59fb5d3e1c30a8 ]

    The loopback flag will be set to 1 by the hardware when the source mac
    address is same as the destination mac address. So the driver don't need
    to compare them.

    Fixes: d6a3627e311c ("RDMA/hns: Optimize wqe buffer set flow for post send")
    Link: https://lore.kernel.org/r/1605526408-6936-4-git-send-email-liweihang@huawei.com
    Signed-off-by: Weihang Li <liweihang@huawei.com>
    Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 9 ---------
    1 file changed, 9 deletions(-)

    diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
    index d127e0e4c3cda..4db7eea3dcec5 100644
    --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
    +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
    @@ -433,8 +433,6 @@ static inline int set_ud_wqe(struct hns_roce_qp *qp,
    unsigned int curr_idx = *sge_idx;
    int valid_num_sge;
    u32 msg_len = 0;
    - bool loopback;
    - u8 *smac;
    int ret;

    valid_num_sge = calc_wr_sge_num(wr, &msg_len);
    @@ -457,13 +455,6 @@ static inline int set_ud_wqe(struct hns_roce_qp *qp,
    roce_set_field(ud_sq_wqe->byte_48, V2_UD_SEND_WQE_BYTE_48_DMAC_5_M,
    V2_UD_SEND_WQE_BYTE_48_DMAC_5_S, ah->av.mac[5]);

    - /* MAC loopback */
    - smac = (u8 *)hr_dev->dev_addr[qp->port];
    - loopback = ether_addr_equal_unaligned(ah->av.mac, smac) ? 1 : 0;
    -
    - roce_set_bit(ud_sq_wqe->byte_40,
    - V2_UD_SEND_WQE_BYTE_40_LBI_S, loopback);
    -
    ud_sq_wqe->msg_len = cpu_to_le32(msg_len);

    /* Set sig attr */
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:12    [W:2.430 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site