lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 180/717] drivers: soc: ti: knav_qmss_queue: Fix error return code in knav_queue_probe
    Date
    From: Zhihao Cheng <chengzhihao1@huawei.com>

    [ Upstream commit 4cba398f37f868f515ff12868418dc28574853a1 ]

    Fix to return the error code from of_get_child_by_name() instaed of 0
    in knav_queue_probe().

    Fixes: 41f93af900a20d1a0a ("soc: ti: add Keystone Navigator QMSS driver")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
    Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/soc/ti/knav_qmss_queue.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
    index 54afa8f7f4087..53e36d4328d1e 100644
    --- a/drivers/soc/ti/knav_qmss_queue.c
    +++ b/drivers/soc/ti/knav_qmss_queue.c
    @@ -1852,9 +1852,10 @@ static int knav_queue_probe(struct platform_device *pdev)
    if (ret)
    goto err;

    - regions = of_get_child_by_name(node, "descriptor-regions");
    + regions = of_get_child_by_name(node, "descriptor-regions");
    if (!regions) {
    dev_err(dev, "descriptor-regions not specified\n");
    + ret = -ENODEV;
    goto err;
    }
    ret = knav_queue_setup_regions(kdev, regions);
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:10    [W:4.053 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site