lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 466/717] net: bcmgenet: Fix a resource leak in an error handling path in the probe functin
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit 4375ada01963d1ebf733d60d1bb6e5db401e1ac6 ]

    If the 'register_netdev()' call fails, we must undo a previous
    'bcmgenet_mii_init()' call.

    Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Acked-by: Florian Fainelli <f.fainelli@gmail.com>
    Link: https://lore.kernel.org/r/20201212182005.120437-1-christophe.jaillet@wanadoo.fr
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
    index be85dad2e3bc4..fcca023f22e54 100644
    --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
    +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
    @@ -4069,8 +4069,10 @@ static int bcmgenet_probe(struct platform_device *pdev)
    clk_disable_unprepare(priv->clk);

    err = register_netdev(dev);
    - if (err)
    + if (err) {
    + bcmgenet_mii_exit(dev);
    goto err;
    + }

    return err;

    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:48    [W:4.353 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site