lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 681/717] iio:imu:bmi160: Fix too large a buffer.
    Date
    From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

    commit dc7de42d6b50a07b37feeba4c6b5136290fcee81 upstream.

    The comment implies this device has 3 sensor types, but it only
    has an accelerometer and a gyroscope (both 3D). As such the
    buffer does not need to be as long as stated.

    Note I've separated this from the following patch which fixes
    the alignment for passing to iio_push_to_buffers_with_timestamp()
    as they are different issues even if they affect the same line
    of code.

    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
    Cc: Daniel Baluta <daniel.baluta@oss.nxp.com>
    Cc: <Stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/20200920112742.170751-5-jic23@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/iio/imu/bmi160/bmi160_core.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/iio/imu/bmi160/bmi160_core.c
    +++ b/drivers/iio/imu/bmi160/bmi160_core.c
    @@ -427,8 +427,8 @@ static irqreturn_t bmi160_trigger_handle
    struct iio_poll_func *pf = p;
    struct iio_dev *indio_dev = pf->indio_dev;
    struct bmi160_data *data = iio_priv(indio_dev);
    - __le16 buf[16];
    - /* 3 sens x 3 axis x __le16 + 3 x __le16 pad + 4 x __le16 tstamp */
    + __le16 buf[12];
    + /* 2 sens x 3 axis x __le16 + 2 x __le16 pad + 4 x __le16 tstamp */
    int i, ret, j = 0, base = BMI160_REG_DATA_MAGN_XOUT_L;
    __le16 sample;


    \
     
     \ /
      Last update: 2020-12-28 15:34    [W:5.386 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site