lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 104/717] MIPS: BCM47XX: fix kconfig dependency bug for BCM47XX_BCMA
    Date
    From: Necip Fazil Yildiran <fazilyildiran@gmail.com>

    [ Upstream commit 3a5fe2fb9635c43359c9729352f45044f3c8df6b ]

    When BCM47XX_BCMA is enabled and BCMA_DRIVER_PCI is disabled, it results
    in the following Kbuild warning:

    WARNING: unmet direct dependencies detected for BCMA_DRIVER_PCI_HOSTMODE
    Depends on [n]: MIPS [=y] && BCMA_DRIVER_PCI [=n] && PCI_DRIVERS_LEGACY [=y] && BCMA [=y]=y
    Selected by [y]:
    - BCM47XX_BCMA [=y] && BCM47XX [=y] && PCI [=y]

    The reason is that BCM47XX_BCMA selects BCMA_DRIVER_PCI_HOSTMODE without
    depending on or selecting BCMA_DRIVER_PCI while BCMA_DRIVER_PCI_HOSTMODE
    depends on BCMA_DRIVER_PCI. This can also fail building the kernel.

    Honor the kconfig dependency to remove unmet direct dependency warnings
    and avoid any potential build failures.

    Fixes: c1d1c5d4213e ("bcm47xx: add support for bcma bus")
    Link: https://bugzilla.kernel.org/show_bug.cgi?id=209879
    Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
    Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/mips/bcm47xx/Kconfig | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/arch/mips/bcm47xx/Kconfig b/arch/mips/bcm47xx/Kconfig
    index 6889f74e06f54..490bb6da74b7e 100644
    --- a/arch/mips/bcm47xx/Kconfig
    +++ b/arch/mips/bcm47xx/Kconfig
    @@ -27,6 +27,7 @@ config BCM47XX_BCMA
    select BCMA
    select BCMA_HOST_SOC
    select BCMA_DRIVER_MIPS
    + select BCMA_DRIVER_PCI if PCI
    select BCMA_DRIVER_PCI_HOSTMODE if PCI
    select BCMA_DRIVER_GPIO
    default y
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 16:19    [W:3.544 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site