Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 30 Dec 2020 14:32:46 +0200 | Subject | Re: [PATCH 5.10 527/717] media: ipu3-cio2: Validate mbus format in setting subdev format |
| |
On Wed, Dec 30, 2020 at 2:25 PM Pavel Machek <pavel@denx.de> wrote:
> > commit a86cf9b29e8b12811cf53c4970eefe0c1d290476 upstream. > > > > Validate media bus code, width and height when setting the subdev format. > > > > This effectively reworks how setting subdev format is implemented in the > > driver. > > Something is wrong here: > > > + fmt->format.code = formats[0].mbus_code; > > + for (i = 0; i < ARRAY_SIZE(formats); i++) {
Looks like 'i = 1' should be...
> > + if (formats[i].mbus_code == fmt->format.code) { > > + fmt->format.code = mbus_code; > > + break; > > + } > > This does not make sense. Loop will always exit during the first > iteration, making the whole loop crazy/redundant.
-- With Best Regards, Andy Shevchenko
| |