lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 036/717] crypto: inside-secure - Fix sizeof() mismatch
    Date
    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit c98e233062cd9d0e2f10e445a671f0799daaef67 ]

    An incorrect sizeof() is being used, sizeof(priv->ring[i].rdr_req) is
    not correct, it should be sizeof(*priv->ring[i].rdr_req). Note that
    since the size of ** is the same size as * this is not causing any
    issues.

    Addresses-Coverity: ("Sizeof not portable (SIZEOF_MISMATCH)")
    Fixes: 9744fec95f06 ("crypto: inside-secure - remove request list to improve performance")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Acked-by: Antoine Tenart <atenart@kernel.org>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/inside-secure/safexcel.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c
    index eb2418450f120..2e1562108a858 100644
    --- a/drivers/crypto/inside-secure/safexcel.c
    +++ b/drivers/crypto/inside-secure/safexcel.c
    @@ -1639,7 +1639,7 @@ static int safexcel_probe_generic(void *pdev,

    priv->ring[i].rdr_req = devm_kcalloc(dev,
    EIP197_DEFAULT_RING_SIZE,
    - sizeof(priv->ring[i].rdr_req),
    + sizeof(*priv->ring[i].rdr_req),
    GFP_KERNEL);
    if (!priv->ring[i].rdr_req)
    return -ENOMEM;
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:10    [W:4.015 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site