lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 096/717] spi: sprd: fix reference leak in sprd_spi_remove
    Date
    From: Zhang Qilong <zhangqilong3@huawei.com>

    [ Upstream commit e4062765bc2a41e025e29dd56bad798505036427 ]

    pm_runtime_get_sync will increment pm usage counter even it
    failed. Forgetting to pm_runtime_put_noidle will result in
    reference leak in sprd_spi_remove, so we should fix it.

    Fixes: e7d973a31c24b ("spi: sprd: Add SPI driver for Spreadtrum SC9860")
    Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
    Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>
    Link: https://lore.kernel.org/r/20201106015035.139574-1-zhangqilong3@huawei.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/spi/spi-sprd.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/spi/spi-sprd.c b/drivers/spi/spi-sprd.c
    index 635738f54c731..b41a75749b498 100644
    --- a/drivers/spi/spi-sprd.c
    +++ b/drivers/spi/spi-sprd.c
    @@ -1010,6 +1010,7 @@ static int sprd_spi_remove(struct platform_device *pdev)

    ret = pm_runtime_get_sync(ss->dev);
    if (ret < 0) {
    + pm_runtime_put_noidle(ss->dev);
    dev_err(ss->dev, "failed to resume SPI controller\n");
    return ret;
    }
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:10    [W:2.404 / U:0.364 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site