lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 108/717] crypto: qat - fix status check in qat_hal_put_rel_rd_xfer()
    Date
    From: Jack Xu <jack.xu@intel.com>

    [ Upstream commit 3b5c130fb2e4c045369791c33c83b59f6e84f7d6 ]

    The return value of qat_hal_rd_ae_csr() is always a CSR value and never
    a status and should not be stored in the status variable of
    qat_hal_put_rel_rd_xfer().

    This removes the assignment as qat_hal_rd_ae_csr() is not expected to
    fail.
    A more comprehensive handling of the theoretical corner case which could
    result in a fail will be submitted in a separate patch.

    Fixes: 8c9478a400b7 ("crypto: qat - reduce stack size with KASAN")
    Signed-off-by: Jack Xu <jack.xu@intel.com>
    Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
    Reviewed-by: Fiona Trahe <fiona.trahe@intel.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/qat/qat_common/qat_hal.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/crypto/qat/qat_common/qat_hal.c b/drivers/crypto/qat/qat_common/qat_hal.c
    index 6b9d47682d04d..52ef80efeddc6 100644
    --- a/drivers/crypto/qat/qat_common/qat_hal.c
    +++ b/drivers/crypto/qat/qat_common/qat_hal.c
    @@ -1146,7 +1146,7 @@ static int qat_hal_put_rel_rd_xfer(struct icp_qat_fw_loader_handle *handle,
    unsigned short mask;
    unsigned short dr_offset = 0x10;

    - status = ctx_enables = qat_hal_rd_ae_csr(handle, ae, CTX_ENABLES);
    + ctx_enables = qat_hal_rd_ae_csr(handle, ae, CTX_ENABLES);
    if (CE_INUSE_CONTEXTS & ctx_enables) {
    if (ctx & 0x1) {
    pr_err("QAT: bad 4-ctx mode,ctx=0x%x\n", ctx);
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:09    [W:2.123 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site