lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 218/717] samples: bpf: Fix lwt_len_hist reusing previous BPF map
    Date
    From: Daniel T. Lee <danieltimlee@gmail.com>

    [ Upstream commit 0afe0a998c40085a6342e1aeb4c510cccba46caf ]

    Currently, lwt_len_hist's map lwt_len_hist_map is uses pinning, and the
    map isn't cleared on test end. This leds to reuse of that map for
    each test, which prevents the results of the test from being accurate.

    This commit fixes the problem by removing of pinned map from bpffs.
    Also, this commit add the executable permission to shell script
    files.

    Fixes: f74599f7c5309 ("bpf: Add tests and samples for LWT-BPF")
    Signed-off-by: Daniel T. Lee <danieltimlee@gmail.com>
    Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
    Link: https://lore.kernel.org/bpf/20201124090310.24374-7-danieltimlee@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    samples/bpf/lwt_len_hist.sh | 2 ++
    samples/bpf/test_lwt_bpf.sh | 0
    2 files changed, 2 insertions(+)
    mode change 100644 => 100755 samples/bpf/lwt_len_hist.sh
    mode change 100644 => 100755 samples/bpf/test_lwt_bpf.sh

    diff --git a/samples/bpf/lwt_len_hist.sh b/samples/bpf/lwt_len_hist.sh
    old mode 100644
    new mode 100755
    index 090b96eaf7f76..0eda9754f50b8
    --- a/samples/bpf/lwt_len_hist.sh
    +++ b/samples/bpf/lwt_len_hist.sh
    @@ -8,6 +8,8 @@ VETH1=tst_lwt1b
    TRACE_ROOT=/sys/kernel/debug/tracing

    function cleanup {
    + # To reset saved histogram, remove pinned map
    + rm /sys/fs/bpf/tc/globals/lwt_len_hist_map
    ip route del 192.168.253.2/32 dev $VETH0 2> /dev/null
    ip link del $VETH0 2> /dev/null
    ip link del $VETH1 2> /dev/null
    diff --git a/samples/bpf/test_lwt_bpf.sh b/samples/bpf/test_lwt_bpf.sh
    old mode 100644
    new mode 100755
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:39    [W:2.112 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site