lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 312/717] ASoC: cros_ec_codec: fix uninitialized memory read
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    [ Upstream commit 7061b8a52296e044eed47b605d136a48da1a7761 ]

    gcc points out a memory area that is copied to a device
    but not initialized:

    sound/soc/codecs/cros_ec_codec.c: In function 'i2s_rx_event':
    arch/x86/include/asm/string_32.h:83:20: error: '*((void *)&p+4)' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    83 | *((int *)to + 1) = *((int *)from + 1);

    Initialize all the unused fields to zero.

    Fixes: 727f1c71c780 ("ASoC: cros_ec_codec: refactor I2S RX")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Acked-by: Tzung-Bi Shih <tzungbi@google.com>
    Link: https://lore.kernel.org/r/20201203225458.1477830-1-arnd@kernel.org
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/codecs/cros_ec_codec.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c
    index 28f039adfa138..5c3b7e5e55d23 100644
    --- a/sound/soc/codecs/cros_ec_codec.c
    +++ b/sound/soc/codecs/cros_ec_codec.c
    @@ -332,7 +332,7 @@ static int i2s_rx_event(struct snd_soc_dapm_widget *w,
    snd_soc_dapm_to_component(w->dapm);
    struct cros_ec_codec_priv *priv =
    snd_soc_component_get_drvdata(component);
    - struct ec_param_ec_codec_i2s_rx p;
    + struct ec_param_ec_codec_i2s_rx p = {};

    switch (event) {
    case SND_SOC_DAPM_PRE_PMU:
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:55    [W:2.247 / U:2.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site