lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 181/717] soc: qcom: initialize local variable
    Date
    From: Tom Rix <trix@redhat.com>

    [ Upstream commit a161ffe4b877721d8917e18e70461d255a090f19 ]

    clang static analysis reports this problem

    pdr_interface.c:596:6: warning: Branch condition evaluates
    to a garbage value
    if (!req.service_path[0])
    ^~~~~~~~~~~~~~~~~~~~

    This check that req.service_path was set in an earlier loop.
    However req is a stack variable and its initial value
    is undefined.

    So initialize req to 0.

    Fixes: fbe639b44a82 ("soc: qcom: Introduce Protection Domain Restart helpers")
    Reviewed-by: Sibi Sankar <sibis@codeaurora.org>
    Signed-off-by: Tom Rix <trix@redhat.com>
    Link: https://lore.kernel.org/r/20200819184637.15648-1-trix@redhat.com
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/soc/qcom/pdr_interface.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/soc/qcom/pdr_interface.c b/drivers/soc/qcom/pdr_interface.c
    index 088dc99f77f3f..f63135c09667f 100644
    --- a/drivers/soc/qcom/pdr_interface.c
    +++ b/drivers/soc/qcom/pdr_interface.c
    @@ -569,7 +569,7 @@ EXPORT_SYMBOL(pdr_add_lookup);
    int pdr_restart_pd(struct pdr_handle *pdr, struct pdr_service *pds)
    {
    struct servreg_restart_pd_resp resp;
    - struct servreg_restart_pd_req req;
    + struct servreg_restart_pd_req req = { 0 };
    struct sockaddr_qrtr addr;
    struct pdr_service *tmp;
    struct qmi_txn txn;
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:39    [W:2.039 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site