lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 005/717] drm/mcde: Fix handling of platform_get_irq() error
    Date
    From: Krzysztof Kozlowski <krzk@kernel.org>

    [ Upstream commit e2dae672a9d5e11856fe30ede63467c65f999a81 ]

    platform_get_irq() returns -ERRNO on error. In such case comparison
    to 0 would pass the check.

    Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Acked-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
    Link: https://patchwork.freedesktop.org/patch/msgid/20200827071107.27429-1-krzk@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/mcde/mcde_drv.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c
    index 92f8bd907193f..210f5e1630081 100644
    --- a/drivers/gpu/drm/mcde/mcde_drv.c
    +++ b/drivers/gpu/drm/mcde/mcde_drv.c
    @@ -331,8 +331,8 @@ static int mcde_probe(struct platform_device *pdev)
    }

    irq = platform_get_irq(pdev, 0);
    - if (!irq) {
    - ret = -EINVAL;
    + if (irq < 0) {
    + ret = irq;
    goto clk_disable;
    }

    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 16:24    [W:3.887 / U:0.948 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site