lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 703/717] memory: renesas-rpc-if: Return correct value to the caller of rpcif_manual_xfer()
    Date
    From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

    commit a0453f4ed066cae651b3119ed11f52d31dae1eca upstream.

    In the error path of rpcif_manual_xfer() the value of ret is overwritten
    by value returned by reset_control_reset() function and thus returning
    incorrect value to the caller.

    This patch makes sure the correct value is returned to the caller of
    rpcif_manual_xfer() by dropping the overwrite of ret in error path.
    Also now we ignore the value returned by reset_control_reset() in the
    error path and instead print a error message when it fails.

    Fixes: ca7d8b980b67f ("memory: add Renesas RPC-IF driver")
    Reported-by: Pavel Machek <pavel@denx.de>
    Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
    Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>
    Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Reviewed-by: Pavel Machek (CIP) <pavel@denx.de>
    Cc: stable@vger.kernel.org
    Link: https://lore.kernel.org/r/20201126191146.8753-2-prabhakar.mahadev-lad.rj@bp.renesas.com
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/memory/renesas-rpc-if.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/memory/renesas-rpc-if.c
    +++ b/drivers/memory/renesas-rpc-if.c
    @@ -508,7 +508,8 @@ exit:
    return ret;

    err_out:
    - ret = reset_control_reset(rpc->rstc);
    + if (reset_control_reset(rpc->rstc))
    + dev_err(rpc->dev, "Failed to reset HW\n");
    rpcif_hw_init(rpc, rpc->bus_size == 2);
    goto exit;
    }

    \
     
     \ /
      Last update: 2020-12-28 15:34    [W:4.459 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site