| Date | Tue, 15 Feb 2011 16:13:08 -0800 | From | Greg KH <> | Subject | [131/272] ext4: fix memory leak in ext4_free_branches |
| |
2.6.37-stable review patch. If anyone has any objections, please let us know.
------------------
From: Theodore Ts'o <tytso@mit.edu>
commit 1c5b9e9065567876c2d4a7a16d78f0fed154a5bf upstream.
Commit 40389687 moved a call to ext4_forget() out of ext4_free_branches and let ext4_free_blocks() handle calling bforget(). But that change unfortunately did not replace the call to ext4_forget() with brelse(), which was needed to drop the in-use count of the indirect block's buffer head, which lead to a memory leak when deleting files that used indirect blocks. Fix this.
Thanks to Hugh Dickins for pointing this out.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- fs/ext4/inode.c | 1 + 1 file changed, 1 insertion(+)
--- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -4349,6 +4349,7 @@ static void ext4_free_branches(handle_t (__le32 *) bh->b_data, (__le32 *) bh->b_data + addr_per_block, depth); + brelse(bh); /* * Everything below this this pointer has been
|