lkml.org 
[lkml]   [2011]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[236/272] mtd: pxa3xx_nand: NULL dereference in pxa3xx_nand_probe
    2.6.37-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Dan Carpenter <error27@gmail.com>

    commit 52d039fdaa78c5a9f9bc2940ad58d7ed76b8336d upstream.

    "info->cmdset" gets dereferenced in __readid() so it needs to be
    initialized earlier in the function. This bug was introduced in
    18c81b1828f8 "mtd: pxa3xx_nand: remove the flash info in driver
    structure".

    Reported-and-tested-by: Sven Neumann <s.neumann@raumfeld.com>
    Signed-off-by: Dan Carpenter <error27@gmail.com>
    Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/mtd/nand/pxa3xx_nand.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/mtd/nand/pxa3xx_nand.c
    +++ b/drivers/mtd/nand/pxa3xx_nand.c
    @@ -885,6 +885,7 @@ static int pxa3xx_nand_detect_config(str
    /* set info fields needed to __readid */
    info->read_id_bytes = (info->page_size == 2048) ? 4 : 2;
    info->reg_ndcr = ndcr;
    + info->cmdset = &default_cmdset;

    if (__readid(info, &id))
    return -ENODEV;
    @@ -915,7 +916,6 @@ static int pxa3xx_nand_detect_config(str

    info->ndtr0cs0 = nand_readl(info, NDTR0CS0);
    info->ndtr1cs0 = nand_readl(info, NDTR1CS0);
    - info->cmdset = &default_cmdset;

    return 0;
    }



    \
     
     \ /
      Last update: 2011-02-16 01:37    [W:0.019 / U:152.604 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site