lkml.org 
[lkml]   [2011]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[130/272] ext4: fix trimming of a single group
    2.6.37-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Jan Kara <jack@suse.cz>

    commit ca6e909f9bebe709bc65a3ee605ce32969db0452 upstream.

    When ext4_trim_fs() is called to trim a part of a single group, the
    logic will wrongly set last block of the interval to 'len' instead
    of 'first_block + len'. Thus a shorter interval is possibly trimmed.
    Fix it.

    CC: Lukas Czerner <lczerner@redhat.com>
    Signed-off-by: Jan Kara <jack@suse.cz>
    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    fs/ext4/mballoc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/ext4/mballoc.c
    +++ b/fs/ext4/mballoc.c
    @@ -4851,7 +4851,7 @@ int ext4_trim_fs(struct super_block *sb,
    if (len >= EXT4_BLOCKS_PER_GROUP(sb))
    len -= (EXT4_BLOCKS_PER_GROUP(sb) - first_block);
    else
    - last_block = len;
    + last_block = first_block + len;

    if (e4b.bd_info->bb_free >= minlen) {
    cnt = ext4_trim_all_free(sb, &e4b, first_block,



    \
     
     \ /
      Last update: 2011-02-16 01:29    [W:4.193 / U:0.404 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site