[lkml]   [2011]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[105/272] ASoC: When disabling WM8994 FLL force a source selection
2.6.37-stable review patch.  If anyone has any objections, please let us know.


From: Mark Brown <>

commit 4514e8997fbefd5befd6176ac9785e287b4daed4 upstream.

When we disable the WM8994 FLL code path sharing means that we end up
writing out a configuration. Currently this is the currently active
input and output frequency (which causes snd_soc_update_bits() to
suppress actual writes both immediately and in the common case where
we reenable the same configuration later) but we allow machine drivers
to pass through a source of zero. Since the register values written
are one less than the source constants this causes corruption of other
bitfields in the register.

Fix this by using the most recently configured FLL source when none is

Signed-off-by: Mark Brown <>
Acked-by: Liam Girdwood <>
Signed-off-by: Greg Kroah-Hartman <>

sound/soc/codecs/wm8994.c | 1 +
1 file changed, 1 insertion(+)

--- a/sound/soc/codecs/wm8994.c
+++ b/sound/soc/codecs/wm8994.c
@@ -2930,6 +2930,7 @@ static int _wm8994_set_fll(struct snd_so
/* Allow no source specification when stopping */
if (freq_out)
return -EINVAL;
+ src = wm8994->fll[id].src;
case WM8994_FLL_SRC_MCLK1:
case WM8994_FLL_SRC_MCLK2:

 \ /
  Last update: 2011-02-16 01:25    [W:0.492 / U:3.284 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site