| Date | Tue, 25 Apr 2023 11:26:32 +0200 | Subject | Re: [PATCH 05/43] dt-bindings: timers: add DT bindings for Cirrus EP93xx | From | Krzysztof Kozlowski <> |
| |
On 24/04/2023 14:34, Nikita Shubin wrote: > This adds device tree bindings for the Cirrus Logic EP93xx > timer block used in these SoCs. > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
Subject: drop second/last, redundant "DT bindings for". The "dt-bindings" prefix is already stating that these are bindings. In all patches.
> --- > > Notes: > Arnd Bergmann: > - replaced ep93xx wildcard with ep9301 > > .../bindings/timer/cirrus,ep93xx-timer.yaml | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 Documentation/devicetree/bindings/timer/cirrus,ep93xx-timer.yaml > > diff --git a/Documentation/devicetree/bindings/timer/cirrus,ep93xx-timer.yaml b/Documentation/devicetree/bindings/timer/cirrus,ep93xx-timer.yaml > new file mode 100644 > index 000000000000..ce8b8a5cb90a > --- /dev/null > +++ b/Documentation/devicetree/bindings/timer/cirrus,ep93xx-timer.yaml > @@ -0,0 +1,41 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/timer/cirrus,ep93xx-timer.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cirrus Logic EP93xx timers bindings
Drop "bindings". In all patches. > + > +maintainers: > + - Hartley Sweeten <hsweeten@visionengravers.com> > + - Alexander Sverdlin <alexander.sverdlin@gmail.com> > + > +properties: > + compatible: > + const: cirrus,ep9301-timer > +
With two fixes above:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
This is an automated instruction, just in case, because many review tags are being ignored. If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply.
https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
Best regards, Krzysztof
|