lkml.org 
[lkml]   [2023]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 28/43] dt-bindings: rtc: Add DT binding m48t86 rtc
On 24/04/2023 11:25:48-0500, Rob Herring wrote:
> On Mon, Apr 24, 2023 at 03:34:44PM +0300, Nikita Shubin wrote:
> > Add YAML bindings for ST M48T86 / Dallas DS12887 RTC.
> >
> > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> > ---
> > .../bindings/rtc/dallas,rtc-m48t86.yaml | 33 +++++++++++++++++++
> > 1 file changed, 33 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/rtc/dallas,rtc-m48t86.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/dallas,rtc-m48t86.yaml b/Documentation/devicetree/bindings/rtc/dallas,rtc-m48t86.yaml
> > new file mode 100644
> > index 000000000000..51f98bdbc385
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/dallas,rtc-m48t86.yaml
> > @@ -0,0 +1,33 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/rtc/dallas,rtc-m48t86.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ST M48T86 / Dallas DS12887 RTC bindings
> > +
> > +maintainers:
> > + - Alessandro Zummo <a.zummo@towertech.it>
> > +
> > +properties:
> > + compatible:
> > + const: dallas,rtc-m48t86
>
> 'rtc-' is redundant. And haven't you mixed up the vendor and part
> number? It should be dallas,ds12887 and/or st,m48t86?
>
> This can probably go in the trivial rtc binding.
>

I was wonderign, is this trivial, even with two regs?

> > +
> > + reg:
> > + maxItems: 2
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + rtc1: rtc@10800000 {
>
> Drop unused labels.
>
> > + compatible = "dallas,rtc-m48t86";
> > + reg = <0x10800000 0x1>, <0x11700000 0x1>;
> > + };
> > +
> > +...
> > +
> > --
> > 2.39.2
> >

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

\
 
 \ /
  Last update: 2023-04-24 18:40    [W:0.250 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site