Messages in this thread | | | Subject | Re: [PATCH 32/43] dt-bindings: gpio: Add DT bindings ep93xx gpio | From | Nikita Shubin <> | Date | Fri, 28 Apr 2023 17:44:22 +0300 |
| |
Hello Linus!
On Wed, 2023-04-26 at 22:48 +0200, Linus Walleij wrote: > On Mon, Apr 24, 2023 at 6:32 PM Rob Herring <robh@kernel.org> wrote: > > On Mon, Apr 24, 2023 at 03:34:48PM +0300, Nikita Shubin wrote: > > > > Add YAML bindings for ep93xx SoC. > > > > > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> > (...) > > > + chip-label: > > > + maxItems: 1 > > > + description: human readable name. > > > > Why do you need this? It's not standard and I don't see other GPIO > > controllers needing it. > > Caught my eye too, Nikita can you live without this and just use > dev_name() > or something to name the chip in Linux? > > If it is to conform to EP93xx documentation naming I guess it should > be > cirrus,ep93xx-gpio-chip-name = "..."; ?
Nah, i should drop it, it was a reverence to people which are sad about gpio index reordering.
Through i like the idea of "cirrus,ep93xx-gpio-chip-name".
> > Yours, > Linus Walleij
| |