lkml.org 
[lkml]   [2023]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v1 14/43] power: reset: Add a driver for the ep93xx reset
    Thu, Jun 01, 2023 at 08:34:05AM +0300, Nikita Shubin kirjoitti:
    > Implement the reset behaviour of the various EP93xx SoCS in drivers/power/reset.
    >
    > It used to be located in arch/arm/mach-ep93xx.

    ...

    > +config POWER_RESET_EP93XX
    > + bool "Cirrus EP93XX reset driver" if COMPILE_TEST

    Can you elaborate this construction, please?

    > + depends on MFD_SYSCON
    > + default ARCH_EP93XX
    > + help
    > + This driver provides restart support for Cirrus EP93XX SoC.
    > +
    > + Say Y here if you have a Cirrus EP93XX SoC and you wish
    > + to have restart support.

    ...

    Missing bits.h

    > +#include <linux/delay.h>
    > +#include <linux/notifier.h>

    > +#include <linux/of_device.h>

    Wrong header. One is mod_devicetable.h, dunno what other implicit dependencies
    you have in mind when added this.

    > +#include <linux/platform_device.h>
    > +#include <linux/reboot.h>

    > +#include <linux/soc/cirrus/ep93xx.h>

    ...

    > + struct notifier_block *res_han;
    > + struct device *dev = &pdev->dev;

    Longer lines first?

    > + int err;
    > +
    > + res_han = devm_kzalloc(&pdev->dev, sizeof(*res_han), GFP_KERNEL);

    You have dev, use it.

    > + if (!res_han)
    > + return -ENOMEM;

    ...

    > + err = register_restart_handler(res_han);
    > + if (err)
    > + dev_err(dev, "can't register restart notifier (err=%d)\n", err);

    return dev_err_probe(...);

    > + return err;
    > +}

    --
    With Best Regards,
    Andy Shevchenko


    \
     
     \ /
      Last update: 2023-06-03 22:26    [W:2.253 / U:0.472 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site