lkml.org 
[lkml]   [2023]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1 09/43] clocksource: ep93xx: Add driver for Cirrus Logic EP93xx
On Wed, Jun 21, 2023 at 11:22 AM Nikita Shubin
<nikita.shubin@maquefel.me> wrote:

...

> > > + irq = irq_of_parse_and_map(np, 0);
> > > + if (irq <= 0) {
> > > + pr_err("ERROR: invalid interrupt number\n");
> > > + ret = -EINVAL;
> >
> > Shadowed error in case of negative returned code. Why?
>
> Majority of clocksource drivers shadow it. Same like above.

It doesn't mean they are correct or using brand new APIs.

Can you use fwnode_irq_get() instead?
The shadowing is most likely due to nasty =0 comparison.

Also that ERROR is a bit weird, pr_err() is already on error level.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2023-06-21 10:30    [W:0.168 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site