Messages in this thread | | | From | Andy Shevchenko <> | Date | Sun, 4 Jun 2023 22:24:55 +0300 | Subject | Re: [PATCH v1 09/43] clocksource: ep93xx: Add driver for Cirrus Logic EP93xx |
| |
On Sun, Jun 4, 2023 at 8:19 PM Arnd Bergmann <arnd@arndb.de> wrote: > On Sat, Jun 3, 2023, at 22:06, andy.shevchenko@gmail.com wrote: > > Thu, Jun 01, 2023 at 08:34:00AM +0300, Nikita Shubin kirjoitti: > >> This us a rewrite of EP93xx timer driver in > >> arch/arm/mach-ep93xx/timer-ep93xx.c trying to do everything > >> the device tree way: > >> > >> - Make every IO-access relative to a base address and dynamic > >> so we can do a dynamic ioremap and get going. > >> - Find register range and interrupt from the device tree. > > > > ... > > > >> +config EP93XX_TIMER > >> + bool "Cirrus Logic ep93xx timer driver" if COMPILE_TEST > > > > This is strange. What do you gain with this "if COMPILE_TEST"? > > This ensures the driver is compiled in an x86 allmodconfig, > like most other clocksource drivers, but it's hidden on > all other configs without EP93xx support.
This is cool!
> As long as the platform selects it, this is the normal > way to add a clocksource driver.
Shall we now require this format of COMPILE_TEST for all new code (which is selectable)?
-- With Best Regards, Andy Shevchenko
| |