Messages in this thread | | | Subject | Re: [PATCH v1 09/43] clocksource: ep93xx: Add driver for Cirrus Logic EP93xx | From | Nikita Shubin <> | Date | Wed, 21 Jun 2023 14:22:37 +0300 |
| |
Hello Andy!
Agreed to almost, still... :
> > ... > > > +static struct ep93xx_tcu *ep93xx_tcu; > > Global?! > Can it be derived from struct clocksource? >
It's look like a common practice for read_sched_clock, even for most new drivers. I would like for comment from Daniel or Thomas before ripping it out.
> > > + irq = irq_of_parse_and_map(np, 0); > > + if (irq <= 0) { > > + pr_err("ERROR: invalid interrupt number\n"); > > + ret = -EINVAL; > > Shadowed error in case of negative returned code. Why?
Majority of clocksource drivers shadow it. Same like above.
All other comments applied - thank you!
| |