lkml.org 
[lkml]   [2023]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v1 28/43] input: keypad: ep93xx: add DT support for Cirrus EP93xx
    Hi Nikita,

    kernel test robot noticed the following build errors:

    [auto build test ERROR on clk/clk-next]
    [also build test ERROR on linusw-pinctrl/devel linusw-pinctrl/for-next linus/master v6.4-rc4 next-20230601]
    [cannot apply to soc/for-next robh/for-next]
    [If your patch is applied to the wrong git tree, kindly drop us a note.
    And when submitting patch, we suggest to use '--base' as documented in
    https://git-scm.com/docs/git-format-patch#_base_tree_information]

    url: https://github.com/intel-lab-lkp/linux/commits/Nikita-Shubin/dt-bindings-soc-Add-Cirrus-EP93xx/20230601-143415
    base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
    patch link: https://lore.kernel.org/r/20230601054549.10843-10-nikita.shubin%40maquefel.me
    patch subject: [PATCH v1 28/43] input: keypad: ep93xx: add DT support for Cirrus EP93xx
    config: arm-randconfig-r046-20230531 (https://download.01.org/0day-ci/archive/20230601/202306012336.68kZBdn0-lkp@intel.com/config)
    compiler: arm-linux-gnueabi-gcc (GCC) 12.3.0
    reproduce (this is a W=1 build):
    mkdir -p ~/bin
    wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
    chmod +x ~/bin/make.cross
    # https://github.com/intel-lab-lkp/linux/commit/79136093fef692a2db3c48c2d30e37310599131f
    git remote add linux-review https://github.com/intel-lab-lkp/linux
    git fetch --no-tags linux-review Nikita-Shubin/dt-bindings-soc-Add-Cirrus-EP93xx/20230601-143415
    git checkout 79136093fef692a2db3c48c2d30e37310599131f
    # save the config file
    mkdir build_dir && cp config build_dir/.config
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=arm olddefconfig
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/input/keyboard/

    If you fix the issue, kindly add following tag where applicable
    | Reported-by: kernel test robot <lkp@intel.com>
    | Closes: https://lore.kernel.org/oe-kbuild-all/202306012336.68kZBdn0-lkp@intel.com/

    All errors (new ones prefixed by >>):

    drivers/input/keyboard/ep93xx_keypad.c: In function 'ep93xx_keypad_probe':
    >> drivers/input/keyboard/ep93xx_keypad.c:262:9: error: implicit declaration of function 'of_property_read_u32' [-Werror=implicit-function-declaration]
    262 | of_property_read_u32(np, "cirrus,debounce-delay-ms", &keypad->debounce);
    | ^~~~~~~~~~~~~~~~~~~~
    cc1: some warnings being treated as errors


    vim +/of_property_read_u32 +262 drivers/input/keyboard/ep93xx_keypad.c

    233
    234 static DEFINE_SIMPLE_DEV_PM_OPS(ep93xx_keypad_pm_ops,
    235 ep93xx_keypad_suspend, ep93xx_keypad_resume);
    236
    237 static int ep93xx_keypad_probe(struct platform_device *pdev)
    238 {
    239 struct device_node *np = pdev->dev.of_node;
    240 struct ep93xx_keypad *keypad;
    241 struct input_dev *input_dev;
    242 int err;
    243
    244 keypad = devm_kzalloc(&pdev->dev, sizeof(*keypad), GFP_KERNEL);
    245 if (!keypad)
    246 return -ENOMEM;
    247
    248 keypad->irq = platform_get_irq(pdev, 0);
    249 if (keypad->irq < 0)
    250 return keypad->irq;
    251
    252 keypad->mmio_base = devm_platform_ioremap_resource(pdev, 0);
    253 if (IS_ERR(keypad->mmio_base))
    254 return PTR_ERR(keypad->mmio_base);
    255
    256 keypad->clk = devm_clk_get(&pdev->dev, NULL);
    257 if (IS_ERR(keypad->clk))
    258 return PTR_ERR(keypad->clk);
    259
    260 keypad->flags = ep93xx_keypad_flags;
    261
    > 262 of_property_read_u32(np, "cirrus,debounce-delay-ms", &keypad->debounce);
    263 of_property_read_u32(np, "cirrus,prescale", &keypad->prescale);
    264
    265 input_dev = devm_input_allocate_device(&pdev->dev);
    266 if (!input_dev)
    267 return -ENOMEM;
    268
    269 keypad->input_dev = input_dev;
    270
    271 input_dev->name = pdev->name;
    272 input_dev->id.bustype = BUS_HOST;
    273 input_dev->open = ep93xx_keypad_open;
    274 input_dev->close = ep93xx_keypad_close;
    275
    276 err = matrix_keypad_build_keymap(NULL, NULL,
    277 EP93XX_MATRIX_ROWS, EP93XX_MATRIX_COLS,
    278 keypad->keycodes, input_dev);
    279 if (err)
    280 return err;
    281
    282 if (keypad->flags & EP93XX_KEYPAD_AUTOREPEAT)
    283 __set_bit(EV_REP, input_dev->evbit);
    284 input_set_drvdata(input_dev, keypad);
    285
    286 err = devm_request_irq(&pdev->dev, keypad->irq,
    287 ep93xx_keypad_irq_handler,
    288 0, pdev->name, keypad);
    289 if (err)
    290 return err;
    291
    292 err = input_register_device(input_dev);
    293 if (err)
    294 return err;
    295
    296 platform_set_drvdata(pdev, keypad);
    297
    298 device_init_wakeup(&pdev->dev, 1);
    299 err = dev_pm_set_wake_irq(&pdev->dev, keypad->irq);
    300 if (err)
    301 dev_warn(&pdev->dev, "failed to set up wakeup irq: %d\n", err);
    302
    303 return 0;
    304 }
    305

    --
    0-DAY CI Kernel Test Service
    https://github.com/intel/lkp-tests/wiki

    \
     
     \ /
      Last update: 2023-06-01 17:24    [W:4.051 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site