| Date | Wed, 24 May 2023 01:31:16 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next 02/30] net: dsa: mt7530: use p5_interface_select as data type for p5_intf_sel |
| |
On Mon, May 22, 2023 at 03:15:04PM +0300, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > Use the p5_interface_select enumeration as the data type for the > p5_intf_sel field. This ensures p5_intf_sel can only take the values > defined in the p5_interface_select enumeration. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > Acked-by: Daniel Golle <daniel@makrotopia.org> > --- > drivers/net/dsa/mt7530.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/dsa/mt7530.h b/drivers/net/dsa/mt7530.h > index 845f5dd16d83..415d8ea07472 100644 > --- a/drivers/net/dsa/mt7530.h > +++ b/drivers/net/dsa/mt7530.h > @@ -675,7 +675,7 @@ struct mt7530_port { > > /* Port 5 interface select definitions */ > enum p5_interface_select { > - P5_DISABLED = 0, > + P5_DISABLED,
Is this change important in this context? Maybe add something to the commit message about it?
|