| Date | Fri, 26 May 2023 16:25:08 +0300 | From | Vladimir Oltean <> | Subject | Re: [PATCH net-next 19/30] net: dsa: mt7530: set interrupt register only for MT7530 |
| |
On Mon, May 22, 2023 at 03:15:21PM +0300, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > Setting this register related to interrupts is only needed for the MT7530 > switch. Make an exclusive check to ensure this. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > Acked-by: Daniel Golle <daniel@makrotopia.org> > Tested-by: Daniel Golle <daniel@makrotopia.org> > ---
Why does it matter? What prompted you to make this change? I guess it's not needed for MT7988? Or the register is not present? Or?...
> drivers/net/dsa/mt7530.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c > index 99f5da8b27be..0c261ef87bee 100644 > --- a/drivers/net/dsa/mt7530.c > +++ b/drivers/net/dsa/mt7530.c > @@ -2029,7 +2029,7 @@ mt7530_setup_irq(struct mt7530_priv *priv) > } > > /* This register must be set for MT7530 to properly fire interrupts */ > - if (priv->id != ID_MT7531) > + if (priv->id == ID_MT7530 || priv->id == ID_MT7621) > mt7530_set(priv, MT7530_TOP_SIG_CTRL, TOP_SIG_CTRL_NORMAL); > > ret = request_threaded_irq(priv->irq, NULL, mt7530_irq_thread_fn, > -- > 2.39.2 >
|