| Date | Fri, 26 May 2023 16:21:19 +0300 | From | Vladimir Oltean <> | Subject | Re: [PATCH net-next 18/30] net: dsa: mt7530: remove .mac_port_config for MT7988 and make it optional |
| |
On Mon, May 22, 2023 at 03:15:20PM +0300, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > For the switch on the MT7988 SoC, the code in mac_port_config for MT7988 is > not needed as the interface of the CPU port is already handled on > mt7988_mac_port_get_caps(). > > Make .mac_port_config optional. Before calling > priv->info->mac_port_config(), if there's no mac_port_config member in the > priv->info table, exit mt753x_mac_config() successfully. > > Remove mac_port_config from the sanity check as the sanity check requires a > pointer to a mac_port_config function to be non-NULL. This will fail for > MT7988 as mac_port_config won't be a member of its info table. > > Co-developed-by: Daniel Golle <daniel@makrotopia.org> > Signed-off-by: Daniel Golle <daniel@makrotopia.org> > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
|