Messages in this thread | | | Date | Sun, 4 Jun 2023 10:05:44 +0300 | Subject | Re: [PATCH net-next 16/30] net: dsa: mt7530: move lowering port 5 RGMII driving to mt7530_setup() | From | Arınç ÜNAL <> |
| |
On 26.05.2023 16:17, Vladimir Oltean wrote: > On Mon, May 22, 2023 at 03:15:18PM +0300, arinc9.unal@gmail.com wrote: >> From: Arınç ÜNAL <arinc.unal@arinc9.com> >> >> Move lowering Tx driving of rgmii on port 5 to right before lowering of Tx >> driving of trgmii on port 6 on mt7530_setup(). >> >> This way, the switch should consume less power regardless of port 5 being >> used. >> >> Tested-by: Arınç ÜNAL <arinc.unal@arinc9.com> >> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> >> --- > > This patch assumes that the MAC has its TXC ticking even when PMCR_TX_EN > is unset. Why would it do that?
It wouldn't. I'll drop this patch, thanks. For reference, PMCR_TX_EN (bit 14) for port 5 is also set in the case of PHY muxing with this code on mt7530_setup_port5() which doesn't use phylink.
/* Setup the MAC by default for the cpu port */ mt7530_write(priv, MT7530_PMCR_P(5), 0x56300);
0x56300 = 0101 0110 0011 0000 0000
Maybe I should make a patch to use the definitions on mt7530.h for this?
Arınç
| |