lkml.org 
[lkml]   [2023]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next 09/30] net: dsa: mt7530: empty default case on mt7530_setup_port5()
On Mon, May 22, 2023 at 03:15:11PM +0300, arinc9.unal@gmail.com wrote:
> default:
> - dev_err(ds->dev, "Unsupported p5_intf_sel %d\n",
> - priv->p5_intf_sel);
> - goto unlock_exit;

You could have probably left a comment though (that doesn't cost in
terms of compiled code):

/* We never call mt7530_setup_port5() with P5_DISABLED */

> + break;
> }

\
 
 \ /
  Last update: 2023-05-24 20:06    [W:0.405 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site