Messages in this thread | | | Date | Thu, 25 May 2023 09:51:12 +0300 | Subject | Re: [PATCH net-next 09/30] net: dsa: mt7530: empty default case on mt7530_setup_port5() | From | Arınç ÜNAL <> |
| |
On 24.05.2023 21:05, Vladimir Oltean wrote: > On Mon, May 22, 2023 at 03:15:11PM +0300, arinc9.unal@gmail.com wrote: >> default: >> - dev_err(ds->dev, "Unsupported p5_intf_sel %d\n", >> - priv->p5_intf_sel); >> - goto unlock_exit; > > You could have probably left a comment though (that doesn't cost in > terms of compiled code): > > /* We never call mt7530_setup_port5() with P5_DISABLED */
I remove P5_DISABLED with later patches so I don't see a reason to add this then remove it on the same patch series.
Arınç
| |