| Date | Tue, 29 Dec 2020 18:58:19 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 5.4 099/453] drm/amdgpu: fix build_coefficients() argument |
| |
Hi!
> From: Arnd Bergmann <arnd@arndb.de> > > [ Upstream commit dbb60031dd0c2b85f10ce4c12ae604c28d3aaca4 ] > > gcc -Wextra warns about a function taking an enum argument > being called with a bool: > > drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c: In function 'apply_degamma_for_user_regamma': > drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c:1617:29: warning: implicit conversion from 'enum <anonymous>' to 'enum dc_transfer_func_predefined' [-Wenum-conversion] > 1617 | build_coefficients(&coeff, true); > > It appears that a patch was added using the old calling conventions > after the type was changed, and the value should actually be 0 > (TRANSFER_FUNCTION_SRGB) here instead of 1 (true).
Yeah, but 4.19 still uses bool there, so this actually introduces a bug.
Please drop. Pavel
> +++ b/drivers/gpu/drm/amd/display/modules/color/color_gamma.c > @@ -1576,7 +1576,7 @@ static void apply_degamma_for_user_regamma(struct pwl_float_data_ex *rgb_regamma > struct pwl_float_data_ex *rgb = rgb_regamma; > const struct hw_x_point *coord_x = coordinates_x; > > - build_coefficients(&coeff, true); > + build_coefficients(&coeff, TRANSFER_FUNCTION_SRGB); > > i = 0; > while (i != hw_points_num + 1) { > -- > 2.27.0 > >
-- http://www.livejournal.com/~pavelmachek [unhandled content-type:application/pgp-signature] |