lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 243/453] scsi: fnic: Fix error return code in fnic_probe()
    Date
    From: Zhang Changzhong <zhangchangzhong@huawei.com>

    [ Upstream commit d4fc94fe65578738ded138e9fce043db6bfc3241 ]

    Return a negative error code from the error handling case instead of 0 as
    done elsewhere in this function.

    Link: https://lore.kernel.org/r/1607068060-31203-1-git-send-email-zhangchangzhong@huawei.com
    Fixes: 5df6d737dd4b ("[SCSI] fnic: Add new Cisco PCI-Express FCoE HBA")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Reviewed-by: Karan Tilak Kumar <kartilak@cisco.com>
    Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/fnic/fnic_main.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c
    index 18584ab27c329..3a2618bcce67b 100644
    --- a/drivers/scsi/fnic/fnic_main.c
    +++ b/drivers/scsi/fnic/fnic_main.c
    @@ -741,6 +741,7 @@ static int fnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
    for (i = 0; i < FNIC_IO_LOCKS; i++)
    spin_lock_init(&fnic->io_req_lock[i]);

    + err = -ENOMEM;
    fnic->io_req_pool = mempool_create_slab_pool(2, fnic_io_req_cache);
    if (!fnic->io_req_pool)
    goto err_out_free_resources;
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:10    [W:2.064 / U:0.556 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site