lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 251/453] usb: oxu210hp-hcd: Fix memory leak in oxu_create
    Date
    From: Zhang Qilong <zhangqilong3@huawei.com>

    [ Upstream commit e5548b05631ec3e6bfdaef1cad28c799545b791b ]

    usb_create_hcd will alloc memory for hcd, and we should
    call usb_put_hcd to free it when adding fails to prevent
    memory leak.

    Fixes: b92a78e582b1a ("usb host: Oxford OXU210HP HCD driver")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
    Link: https://lore.kernel.org/r/20201123145809.1456541-1-zhangqilong3@huawei.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/host/oxu210hp-hcd.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/usb/host/oxu210hp-hcd.c b/drivers/usb/host/oxu210hp-hcd.c
    index e67242e437edc..65985247fc00f 100644
    --- a/drivers/usb/host/oxu210hp-hcd.c
    +++ b/drivers/usb/host/oxu210hp-hcd.c
    @@ -4149,8 +4149,10 @@ static struct usb_hcd *oxu_create(struct platform_device *pdev,
    oxu->is_otg = otg;

    ret = usb_add_hcd(hcd, irq, IRQF_SHARED);
    - if (ret < 0)
    + if (ret < 0) {
    + usb_put_hcd(hcd);
    return ERR_PTR(ret);
    + }

    device_wakeup_enable(hcd->self.controller);
    return hcd;
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 16:40    [W:2.912 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site