lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 114/453] spi: spi-ti-qspi: fix reference leak in ti_qspi_setup
    Date
    From: Zhang Qilong <zhangqilong3@huawei.com>

    [ Upstream commit 45c0cba753641e5d7c3207f04241bd0e7a021698 ]

    pm_runtime_get_sync will increment pm usage counter even it
    failed. Forgetting to pm_runtime_put_noidle will result in
    reference leak in ti_qspi_setup, so we should fix it.

    Fixes: 505a14954e2d7 ("spi/qspi: Add qspi flash controller")
    Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
    Link: https://lore.kernel.org/r/20201103140947.3815-1-zhangqilong3@huawei.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/spi/spi-ti-qspi.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
    index 66dcb61285392..cad2abcbd9c78 100644
    --- a/drivers/spi/spi-ti-qspi.c
    +++ b/drivers/spi/spi-ti-qspi.c
    @@ -176,6 +176,7 @@ static int ti_qspi_setup(struct spi_device *spi)

    ret = pm_runtime_get_sync(qspi->dev);
    if (ret < 0) {
    + pm_runtime_put_noidle(qspi->dev);
    dev_err(qspi->dev, "pm_runtime_get_sync() failed\n");
    return ret;
    }
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 14:44    [W:3.222 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site