lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 334/453] ALSA: hda: Fix regressions on clear and reconfig sysfs
    Date
    From: Takashi Iwai <tiwai@suse.de>

    commit 2506318e382c4c7daa77bdc48f80a0ee82804588 upstream.

    It seems that the HD-audio clear and reconfig sysfs don't work any
    longer after the recent driver core change. There are multiple issues
    around that: the linked list corruption and the dead device handling.
    The former issue is fixed by another patch for the driver core itself,
    while the latter patch needs to be addressed in HD-audio side.

    This patch corresponds to the latter, it recovers those broken
    functions by replacing the device detach and attach actions with the
    standard core API functions, which are almost equivalent with unbind
    and bind actions.

    Fixes: 654888327e9f ("driver core: Avoid binding drivers to dead devices")
    Cc: <stable@vger.kernel.org>
    BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=209207
    Link: https://lore.kernel.org/r/20201209150119.7705-1-tiwai@suse.de
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/pci/hda/hda_codec.c | 2 +-
    sound/pci/hda/hda_sysfs.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    --- a/sound/pci/hda/hda_codec.c
    +++ b/sound/pci/hda/hda_codec.c
    @@ -1798,7 +1798,7 @@ int snd_hda_codec_reset(struct hda_codec
    return -EBUSY;

    /* OK, let it free */
    - snd_hdac_device_unregister(&codec->core);
    + device_release_driver(hda_codec_dev(codec));

    /* allow device access again */
    snd_hda_unlock_devices(bus);
    --- a/sound/pci/hda/hda_sysfs.c
    +++ b/sound/pci/hda/hda_sysfs.c
    @@ -139,7 +139,7 @@ static int reconfig_codec(struct hda_cod
    "The codec is being used, can't reconfigure.\n");
    goto error;
    }
    - err = snd_hda_codec_configure(codec);
    + err = device_reprobe(hda_codec_dev(codec));
    if (err < 0)
    goto error;
    err = snd_card_register(codec->card);

    \
     
     \ /
      Last update: 2020-12-28 14:54    [W:2.173 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site