lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 177/453] media: max2175: fix max2175_set_csm_mode() error code
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 9b1b0cb0636166187478ef68d5b95f5caea062ec ]

    This is supposed to return negative error codes but the type is bool so
    it returns true instead.

    Fixes: b47b79d8a231 ("[media] media: i2c: max2175: Add MAX2175 support")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/i2c/max2175.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/i2c/max2175.c b/drivers/media/i2c/max2175.c
    index 19a3ceea3bc20..a62d7e2ac3567 100644
    --- a/drivers/media/i2c/max2175.c
    +++ b/drivers/media/i2c/max2175.c
    @@ -503,7 +503,7 @@ static void max2175_set_bbfilter(struct max2175 *ctx)
    }
    }

    -static bool max2175_set_csm_mode(struct max2175 *ctx,
    +static int max2175_set_csm_mode(struct max2175 *ctx,
    enum max2175_csm_mode new_mode)
    {
    int ret = max2175_poll_csm_ready(ctx);
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 16:42    [W:2.585 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site