| Date | Thu, 24 Apr 2014 18:01:43 +0800 | Subject | Re: [PATCH 17/28] nios2: Signal handling support | From | Ley Foon Tan <> |
| |
On Sun, Apr 20, 2014 at 3:29 AM, Richard Weinberger <richard.weinberger@gmail.com> wrote:
>> + >> + /* Default to using normal stack. */ >> + usp = regs->sp; >> + >> + /* This is the X/Open sanctioned signal stack switching. */ >> + if ((ka->sa.sa_flags & SA_ONSTACK) && (current->sas_ss_sp != 0)) { >> + if (!on_sig_stack(usp)) >> + usp = current->sas_ss_sp + current->sas_ss_size; >> + } > > You can use sigsp() here. Okay.
>> + >> + push_cache((unsigned long) &frame->retcode); >> + >> + /* Set up registers for signal handler */ >> + regs->sp = (unsigned long) frame; >> + regs->r4 = (unsigned long) (current_thread_info()->exec_domain >> + && current_thread_info()->exec_domain->signal_invmap >> + && sig < 32 >> + ? current_thread_info()->exec_domain->signal_invmap[sig] >> + : sig); > > Does nios2 really need signal translation and supports execution domains? Nios2 have one default "default_exec_domain" only. So, we can change this to "regs->r4 = sig;". BTW, most of the architectures have similar code.
>> + >> +/* >> + * Note that 'init' is a special process: it doesn't get signals it doesn't >> + * want to handle. Thus you cannot kill init even with a SIGKILL even by >> + * mistake. >> + */ Will remove this.
>> + >> +asmlinkage void do_notify_resume(struct pt_regs *regs, sigset_t *oldset, >> + int in_syscall) >> +{ >> + pr_debug("--> ENTERING %s\n", __func__); > > Please remove such printk()s. > If you need to know which functions get called, use ftrace. Okay, will remove this.
Regards Ley Foon
|