lkml.org 
[lkml]   [2014]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 20/28] nios2: Time keeping
From
On Tue, Apr 22, 2014 at 9:44 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 18 April 2014, Ley Foon Tan wrote:
>> +static inline unsigned long read_timersnapshot(void)
>> +{
>> + unsigned long count;
>> +
>> + outw(0, timer_membase + ALTERA_TIMER_SNAPL_REG);
>> + count =
>> + inw(timer_membase + ALTERA_TIMER_SNAPH_REG) << 16 |
>> + inw(timer_membase + ALTERA_TIMER_SNAPL_REG);
>> +
>> + return count;
>> +}
>> +
>> +static inline void write_timerperiod(unsigned long period)
>> +{
>> + outw(period, timer_membase + ALTERA_TIMER_PERIODL_REG);
>> + outw(period >> 16, timer_membase + ALTERA_TIMER_PERIODH_REG);
>> +}
>
> It's wrong to use 'outw' if this device is not on an PC-style ISA bus,
> which I assume it is not. Since timer_membase is an __iomem pointer,
> I'm sure you want to use writew() instead.
>
> Arnd
Sure, will change all outw() to writew() and inw() to readw().

Ley Foon


\
 
 \ /
  Last update: 2014-04-23 05:41    [W:0.101 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site