lkml.org 
[lkml]   [2014]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 06/28] nios2: Memory management
From
On Wed, Apr 23, 2014 at 12:24 AM, Sam Ravnborg <sam@ravnborg.org> wrote:
>> Other than being "pretty" the above fix is to remove a mismatch type
>> warning. You can get rid of the warning in different ways:
>>
>> ifdef __ASSEMBLY__
>> define PAGE_SIZE 4096
>> else
>> define PAGE_SIZE 4096UL
>> endif
>
> The usual way to do this is as follows:
> #include <linux/const.h>
>
> #define PAGE_SHIFT 12
> #define PAGE_SIZE (_AC(1, UL) << PAGE_SHIFT)
> #define PAGE_MASK (~(PAGE_SIZE-1))
>
> _AC(1, UL) expands to 1 for assembler and 1UL for C code.
>
> This is also what was suggested above.
>
> Please follow this scheme for nios2 too.
>
> Sam
Sure, will change to this way.

Thanks.

Ley Foon


\
 
 \ /
  Last update: 2014-04-23 05:41    [W:0.675 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site