lkml.org 
[lkml]   [2014]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/28] nios2: Memory management
On 2014-04-22 at 16:24:43 +0200, Ezequiel Garcia <ezequiel.garcia@free-electrons.com> wrote:
> Hi Ley Foon,
>
> On Apr 18, Ley Foon Tan wrote:
> > +/*
> > + * PAGE_SHIFT determines the page size
> > + */
> > +#define PAGE_SHIFT 12
> > +#define PAGE_SIZE 4096
> > +#define PAGE_MASK (~(PAGE_SIZE - 1))
> > +
>
> How about something like this:
>
> /* PAGE_SHIFT determines the page size */
> #define PAGE_SHIFT 12
> #define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT)
> #define PAGE_MASK (~((1 << PAGE_SHIFT) - 1))
>
> Otherwise, the PAGE_SIZE macro above produces some warnings, IIRC.

AFAIR old nios2 GCC versions (the 4.1 version from Windriver, IIRC)
would complain about something like the above, that's the reason I added
an explicit value for PAGE_SIZE back then.

I assume with the new nios2 GCC this should no longer be necessary and
Ezequiel's fix should be fine.


\
 
 \ /
  Last update: 2014-04-26 17:41    [W:0.147 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site