Messages in this thread | | | Date | Wed, 23 Apr 2014 09:24:49 +0200 | Subject | Re: [PATCH 06/28] nios2: Memory management | From | Geert Uytterhoeven <> |
| |
Hi Sam,
On Tue, Apr 22, 2014 at 6:24 PM, Sam Ravnborg <sam@ravnborg.org> wrote: > #define PAGE_SIZE (_AC(1, UL) << PAGE_SHIFT) > #define PAGE_MASK (~(PAGE_SIZE-1)) > > _AC(1, UL) expands to 1 for assembler and 1UL for C code.
Ideally, PAGE_SIZE should be size_t, not unsigned long, avoiding issues like https://lkml.org/lkml/2014/4/13/78. But currently it's unsigned long everywhere, so nios2 should be consistent.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |