Messages in this thread | | | Date | Mon, 21 Apr 2014 22:46:34 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 16/28] nios2: System calls handling |
| |
Hi!
> > Also... explanation why you need this syscall while other > > architectures live happily without it would be nice. > This syscall exist in nios2 port since old days and some users already > used it for sometimes. > Like mentioned by Greet, 12 our of 28 architectures provide such a syscall.
Would it make sense to create common code for this syscall?
> >> +/* sys_cacheflush -- flush the processor cache. */ > >> +asmlinkage int sys_cacheflush(unsigned long addr, unsigned long len, > >> + unsigned int op) > >> +{ > >> + struct vm_area_struct *vma; > >> + > >> + if (len == 0) > >> + return 0; > > > > op is being ignored? You should remove it... or if (op) return -EINVAL > > if you want future extensions. > Yes, op argument is being ignored. Okay, will add the return -EINVAL > if op is non-zero.
Thanks! Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |